Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new setting 'Hide conversation after closing' #30591

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 6, 2023

Proposed changes (including videos or screenshots)

Issue(s)

SUP-359
OC-860

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: f01b939

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #30591 (f01b939) into develop (e24d071) will decrease coverage by 0.16%.
The diff coverage is 35.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30591      +/-   ##
===========================================
- Coverage    51.29%   51.14%   -0.16%     
===========================================
  Files          811      806       -5     
  Lines        15058    15105      +47     
  Branches      2751     2790      +39     
===========================================
+ Hits          7724     7725       +1     
- Misses        6927     6945      +18     
- Partials       407      435      +28     
Flag Coverage Δ
e2e 48.46% <35.29%> (-0.11%) ⬇️
unit 64.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@renatobecker renatobecker added this to the 6.4.1 milestone Oct 9, 2023
@aleksandernsilva aleksandernsilva modified the milestones: 6.4.1, 6.4.2 Oct 9, 2023
MartinSchoeler
MartinSchoeler previously approved these changes Oct 9, 2023
MartinSchoeler
MartinSchoeler previously approved these changes Oct 11, 2023
KevLehman
KevLehman previously approved these changes Oct 11, 2023
@aleksandernsilva aleksandernsilva removed this from the 6.4.2 milestone Oct 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 16, 2023
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 17, 2023 17:56
@aleksandernsilva aleksandernsilva requested review from a team as code owners October 17, 2023 17:56
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2023
@aleksandernsilva aleksandernsilva added this to the 6.5.0 milestone Oct 18, 2023
@aleksandernsilva aleksandernsilva added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 18, 2023
@kodiakhq kodiakhq bot merged commit f3dd127 into develop Oct 18, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the feat/hide-chat-after-closing-setting branch October 18, 2023 18:05
@renatobecker renatobecker modified the milestones: 6.5.0, 6.4.3 Oct 19, 2023
gabriellsh added a commit that referenced this pull request Oct 20, 2023
…chat.postMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  docs: Fixed typo in FEATURES.md (#30683)
  refactor(uikit): uikit interactions (#30534)
  feat: add trial flag to licenses.info endpoint (#30662)
  refactor: Small files to typescript (#30665)
  feat: Added new setting 'Hide conversation after closing' (#30591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants